| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Let's get rid of SPI_push/SPI_pop |
| Date: | 2016-11-07 15:34:21 |
| Message-ID: | CAFj8pRBT9ZY2ccGbZNPhFheEmkLOEmENtX7ESBYx5=VLD5u8+Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2016-11-07 15:47 GMT+01:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> > 2016-11-07 2:16 GMT+01:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> >> So I think we should just delete these functions and adjust SPI_connect
> >> and SPI_finish so that they just push/pop a context level
> unconditionally.
> >> (Which will make them simpler, not more complicated.)
>
> > cannot be there some performance impacts?
>
> Any impact will be for the better, since we're removing logic.
> I haven't gone through it in detail, but it might be as simple
> as removing _SPI_curid and code that manipulates it.
>
ok
Pavel
>
> regards, tom lane
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2016-11-07 15:35:10 | Re: Detect supported SET parameters when pg_restore is run |
| Previous Message | Tom Lane | 2016-11-07 15:29:15 | Re: Add PGDLLEXPORT to PG_FUNCTION_INFO_V1 |