From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch to improve a few appendStringInfo* calls |
Date: | 2015-12-21 14:40:40 |
Message-ID: | CAFj8pRBP-_MZKN3CDd1xmds2P_zZiop3iemt1O-1iAmXVELeEQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2015-12-21 13:58 GMT+01:00 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Thu, Jul 2, 2015 at 6:08 AM, David Rowley
> <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> >> I left out the changes like
> >>
> >>> - appendStringInfoString(&collist, buf.data);
> >>> + appendBinaryStringInfo(&collist, buf.data, buf.len);
> >>
> >>
> >> because they're not an improvement in readablity, IMHO, and they were
> not
> >> in performance-critical paths.
> >
> > Perhaps we can come up with appendStringInfoStringInfo at some later
> date.
>
> concatenateStringInfo?
>
concatStringInfo ?
Pavel
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-12-21 14:42:00 | Re: Experimental evaluation of PostgreSQL's query optimizer |
Previous Message | Robert Haas | 2015-12-21 14:38:26 | Re: ToDo list update for BRIN indexes |