Re: review: Non-recursive processing of AND/OR lists

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Gurjeet Singh <gurjeet(at)singh(dot)im>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: review: Non-recursive processing of AND/OR lists
Date: 2013-06-30 17:08:07
Message-ID: CAFj8pRBFzkAs7B5aYyKZq9KJ77L3mu6qrTRy8PZ8yCYj2pvLBw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2013/6/30 Gurjeet Singh <gurjeet(at)singh(dot)im>:
> On Sun, Jun 30, 2013 at 11:46 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
>>
>> 2013/6/30 Gurjeet Singh <gurjeet(at)singh(dot)im>:
>> > On Sun, Jun 30, 2013 at 11:13 AM, Pavel Stehule
>> > <pavel(dot)stehule(at)gmail(dot)com>
>> > wrote:
>> >
>> > How about naming those 3 variables as follows:
>> >
>> > root_expr_kind
>> > root_expr_name
>> > root_bool_expr_type
>>
>> +1
>
>
> Thanks. Attached is the patch with that change. I'll update the commitfest
> entry with a link to this email.

ok

I chechecked it - patched without warnings, all tests passed

It is ready for commit

Regards

Pavel

>
> --
> Gurjeet Singh
>
> http://gurjeet.singh.im/
>
> EnterpriseDB Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2013-06-30 18:01:53 Re: fallocate / posix_fallocate for new WAL file creation (etc...)
Previous Message Gurjeet Singh 2013-06-30 16:38:29 Fwd: review: Non-recursive processing of AND/OR lists