Re: proposal: schema variables

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Erik Rijkers <er(at)xs4all(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, DUVAL REMI <REMI(dot)DUVAL(at)cheops(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PegoraroF10 <marcos(at)f10(dot)com(dot)br>
Subject: Re: proposal: schema variables
Date: 2025-09-15 16:55:44
Message-ID: CAFj8pRBDVrm_Ju9RJe1J1Yhb5BPtOq49cQH7RvQ_ZPuh__Nrcw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-performance

Hi

po 15. 9. 2025 v 10:21 odesílatel Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
napsal:

> Hi
>
> On 9/13/25 11:28, Pavel Stehule wrote:
> >
> > minor change (after private talk with Jim Jones)
> >
>
> After another pass, there are a few additional tests that should be
> included in this patch:
>
>
> == Additional tests for GRANT x ON VARIABLE ==
> ==============================================
>
> We wanna make sure the proper error message is raised.
>
> postgres=# GRANT INSERT ON VARIABLE var TO jim;
> ERROR: invalid privilege type INSERT for session variable
>
> postgres=# GRANT DELETE ON VARIABLE var TO jim;
> ERROR: invalid privilege type DELETE for session variable
>
>
> == Tests for ALTER DEFAULT PRIVILEGES ==
> ========================================
>
> I couldn't find regression tests for ALTER DEFAULT PRIVILEGES ... if I
> haven't just missed them, I think they'd be a nice addition.
>
> postgres=# ALTER DEFAULT PRIVILEGES IN SCHEMA s GRANT UPDATE ON
> VARIABLES TO jim;
> ALTER DEFAULT PRIVILEGES
>
> postgres=# ALTER DEFAULT PRIVILEGES IN SCHEMA s GRANT INSERT ON
> VARIABLES TO jim;
> ERROR: invalid privilege type INSERT for session variable
>
> postgres=# ALTER DEFAULT PRIVILEGES IN SCHEMA s GRANT DELETE ON
> VARIABLES TO jim;
> ERROR: invalid privilege type DELETE for session variable
>
> postgres=# ALTER DEFAULT PRIVILEGES IN SCHEMA s GRANT SELECT ON
> VARIABLES TO jim;
> ALTER DEFAULT PRIVILEGES
>

done

Regards

Pavel

>
>
> Best, Jim
>

Attachment Content-Type Size
v20250915-0012-function-pg_get_session_variables_memory-for-cleanin.patch text/x-patch 4.9 KB
v20250915-0014-memory-cleaning-after-DROP-VARIABLE.patch text/x-patch 23.4 KB
v20250915-0011-LET-command-assign-a-result-of-expression-to-the-ses.patch text/x-patch 52.3 KB
v20250915-0015-plpgsql-tests.patch text/x-patch 13.6 KB
v20250915-0013-DISCARD-VARIABLES.patch text/x-patch 10.2 KB
v20250915-0009-fill-an-auxiliary-buffer-with-values-of-session-vari.patch text/x-patch 19.5 KB
v20250915-0010-svariableReceiver.patch text/x-patch 8.9 KB
v20250915-0008-collect-session-variables-used-in-plan-and-assign-pa.patch text/x-patch 16.5 KB
v20250915-0007-local-HASHTAB-for-currently-used-session-variables-a.patch text/x-patch 14.1 KB
v20250915-0006-session-variable-fences-parsing.patch text/x-patch 32.4 KB
v20250915-0005-support-of-session-variables-for-pg_dump.patch text/x-patch 15.3 KB
v20250915-0004-support-of-session-variables-for-psql.patch text/x-patch 22.8 KB
v20250915-0003-GRANT-REVOKE-variable.patch text/x-patch 54.4 KB
v20250915-0002-CREATE-DROP-ALTER-VARIABLE.patch text/x-patch 80.4 KB
v20250915-0001-introduce-new-class-catalog-pg_variable.patch text/x-patch 16.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2025-09-15 17:00:18 Re: Make COPY format extendable: Extract COPY TO format implementations
Previous Message Masahiko Sawada 2025-09-15 16:45:09 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

Browse pgsql-performance by date

  From Date Subject
Previous Message Jim Jones 2025-09-15 08:21:33 Re: proposal: schema variables