Re: proposal: plpgsql, new check for extra_errors - strict_expr_check

Hi

st 30. 7. 2025 v 0:17 odesílatel Kirk Wolak <wolakk(at)gmail(dot)com> napsal:

> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: tested, passed
>
> This is properly isolated, only available when turned on.
> I ran this through the examples as specified. Then through OUR 1,000 +
> procedures.
> I used \set ON_ERROR_STOP 'on'
> and loaded a script that recreates all of our procedures/functions.
> In both modes. And it found nothing. (As expected, but that is 1,000
> procedures from the wild).
> I forced 1 procedure to have the problem.
> As expected, when enabled, this STOPPED and pointed out the error.
> Without this setting, the code loaded clean.
>
> Small note: The doc says this check is allowed only when
> plpgsql.extra_errors is set to "strict_expr_check"...
> But it also is obviously in effect when that is set to 'all' for reasons
> that should be completely obvious.
>

I removed this sentence from doc. Now, it is consistent with other plpgsql
extra checks.

>
> The new status of this patch is: Ready for Committer
>

thank you for review

updated patch attached (only documentation was changed, one sentence
removed)

Regards

Pavel