From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: proposal: searching in array function - array_position |
Date: | 2015-03-20 17:43:59 |
Message-ID: | CAFj8pRAsDKQtPnMHW+fc-N+gbvxb_Ed1_fXSEAPRgSaY1-Q3hA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2015-03-20 18:29 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
> Pavel Stehule wrote:
> > 2015-03-20 17:49 GMT+01:00 Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>:
> >
> > > There's an issue when the array's lower bound isn't 1:
> > >
> > > select array_offset('[2:4]={1,2,3}'::int[], 1);
> > > array_offset
> > > --------------
> > > 1
> > > (1 row)
> > >
> > > whereas I would expect this to return 2. Similarly for
> > > array_offsets(), so the offsets can be used as indexes into the
> > > original array.
> > >
> >
> > I am thinking, so it is ok - it returns a offset, not position.
>
> So you can't use it as a subscript? That sounds unfriendly. Almost
> every function using this will be subtly broken.
>
depends what you want. It means - it is on Nth position from start. So it
is useful when iterate over array, because it is safe against different
array start dimensions. it works, if you use it as "offset". It is named
"array_offset"
It can be changed and renamed to array_position - it is simple fix. But I
am not sure, if it is better.
Regards
Pavel
> --
> Álvaro Herrera http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-03-20 17:45:25 | Re: Remove fsync ON/OFF as a visible option? |
Previous Message | Alvaro Herrera | 2015-03-20 17:29:42 | Re: proposal: searching in array function - array_position |