From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: proposal - psql: possibility to specify sort for describe commands, when size is printed |
Date: | 2017-09-19 16:54:03 |
Message-ID: | CAFj8pRAqo98DygF04LWbeJtR+g=2OVr+WvFP4O2kw+JZru9JTw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
2017-09-19 16:14 GMT+02:00 Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>:
> On Fri, Sep 8, 2017 at 7:13 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
>
>> 2017-08-16 14:06 GMT+02:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>>
>>> Hi
>>>
>>> 2017-08-15 4:37 GMT+02:00 Peter Eisentraut <
>>> peter(dot)eisentraut(at)2ndquadrant(dot)com>:
>>>
>>>> On 3/11/17 07:06, Pavel Stehule wrote:
>>>> > I am sending a updated version with separated sort direction in
>>>> special
>>>> > variable
>>>>
>>>> This patch also needs a rebase.
>>>>
>>>
>>> I am sending rebased patch
>>>
>>
>> rebased again + fix obsolete help
>>
>
> For me, patch applies cleanly, builds and passed regression tests.
> However, patch misses regression tests covering added functionality.
>
I am not sure if there are any tests related to output of \dt+ commands -
there result is platform depend.
> Patch is definitely harmless, i.e. it doesn't affect anybody who doesn't
> use new functionality.
> But I still would prefer ordering to be options of \d* commands while psql
> variables be defaults for those options...
>
I understand
a) I don't think so commands like \dt++ (or similar) is good idea - these
commands should be simple how it is possible
b) this patch doesn't block any other design - more it opens the door
because the executive part will be implemented and users can have a
experience with with different output sorts - so if people will need more
quick change of result sort, then the work in this area will continue.
Regards
Pavel
> ------
> Alexander Korotkov
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
>
From | Date | Subject | |
---|---|---|---|
Next Message | chiru r | 2017-09-19 16:57:04 | USER Profiles for PostgreSQL |
Previous Message | Tom Lane | 2017-09-19 16:53:28 | Re: pgsql: Add test for postmaster crash restarts. |