From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
Subject: | Re: patch: function xmltable |
Date: | 2017-03-02 17:46:23 |
Message-ID: | CAFj8pRAnbh+jS3+zy=ZhV7bYMynHALQrwYAuGh+2-to3Grc52A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dne 2. 3. 2017 18:14 napsal uživatel "Alvaro Herrera" <
alvherre(at)2ndquadrant(dot)com>:
Pavel Stehule wrote:
> It is documented already
>
> "If the <literal>PATH</> matches an empty tag the result is an empty
string"
Hmm, okay. But what we have here is not an empty tag, but a tag that is
completely missing. I don't think those two cases should be treated in
the same way ...
this information is not propagated from libxml2.
> Attached new patch
>
> cleaned documentation
> regress tests is more robust
> appended comment in src related to generating empty string for empty tag
Thanks, I incorporated those changes. Here's v46. I rewrote the
documentation, and fixed a couple of incorrectly copied&pasted comments
in the new executor code; I think that one looks good. In the future we
could rewrite it to avoid the need for a tuplestore, but I think the
current approach is good enough for a pg10 implementation.
Barring serious problems, I intend to commit this later today.
thank you very much
regards
Pavel
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-03-02 17:59:58 | Re: I propose killing PL/Tcl's "modules" infrastructure |
Previous Message | Masahiko Sawada | 2017-03-02 17:16:32 | Two phase commit in ECPG |