Re: proposal: PL/Pythonu - function ereport

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Catalin Iacob <iacobcatalin(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: PL/Pythonu - function ereport
Date: 2015-11-27 16:57:04
Message-ID: CAFj8pRAimXv+MAez-VXKm=2qhrs0yCML38d=BJH_o8mMaprHFQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

2015-11-27 17:54 GMT+01:00 Teodor Sigaev <teodor(at)sigaev(dot)ru>:

> Is this patch in 'Waiting on Author' state actually?

yes

I'll try redesign patch by Peter's proposal

Pavel

>
>
> I don't think it's right to reuse SPIError for this. SPIError is
>>> clearly meant to signal an error in the SPI calls. Of course, we
>>> can't
>>> stop users from raising whatever exception they want, but if we're
>>> going
>>> to advertise that users can raise exceptions, then we should create
>>> separate exception classes.
>>>
>>> I suppose the proper way to set this up would be to create a base
>>> class
>>> like plpy.Error and derive SPIError from that.
>>>
>>>
>>> Do you have some ideas about the name of this class?
>>>
>>
>> I think plpy.Error is fine.
>>
>>
>>
>>
> --
> Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
> WWW:
> http://www.sigaev.ru/
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Костя Кузнецов 2015-11-27 17:00:36 Re: New gist vacuum.
Previous Message Teodor Sigaev 2015-11-27 16:54:37 Re: proposal: PL/Pythonu - function ereport