Re: patch: function xmltable

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: function xmltable
Date: 2016-12-05 06:21:37
Message-ID: CAFj8pRAimQQuK4s9uhyiP0JBVZHYgiaqqdrMOcERuScQKwwiZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

2016-12-05 0:45 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:

> Pavel Stehule wrote:
> > 2016-12-04 23:00 GMT+01:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>
> > > I am not sure if I understand well to your ideas - please, check
> attached
> > > patch.
>
> Thanks, that's what I meant, but I think you went a bit overboard
> creating new functions in execQual -- seems to me it would work just
> fine to have the memory switches in the same function, rather than
> having a number of separate functions just to change the context then
> call the method. Please remove these shim functions.
>

done

>
> Also, you forgot to remove the now-unused per_rowset_memcxt struct member.
>

done

>
> Also, please rename "rc" to something more meaningful -- maybe
> "rowcount" is good enough. And "doc" would perhaps be better as
> "document".
>

done

Regards

Pavel

>
> I'm not completely sure the structs are really sensible yet. I may do
> some more changes tomorrow.
>
> --
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>

Attachment Content-Type Size
xmltable-20.patch text/x-patch 166.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-12-05 06:26:09 Re: commitfest 2016-11 status summary
Previous Message Haribabu Kommi 2016-12-05 05:55:11 Re: Transactions involving multiple postgres foreign servers