| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch: function xmltable |
| Date: | 2016-12-04 23:45:54 |
| Message-ID: | 20161204234554.nti6xxx2j5l7533n@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pavel Stehule wrote:
> 2016-12-04 23:00 GMT+01:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
> > I am not sure if I understand well to your ideas - please, check attached
> > patch.
Thanks, that's what I meant, but I think you went a bit overboard
creating new functions in execQual -- seems to me it would work just
fine to have the memory switches in the same function, rather than
having a number of separate functions just to change the context then
call the method. Please remove these shim functions.
Also, you forgot to remove the now-unused per_rowset_memcxt struct member.
Also, please rename "rc" to something more meaningful -- maybe
"rowcount" is good enough. And "doc" would perhaps be better as
"document".
I'm not completely sure the structs are really sensible yet. I may do
some more changes tomorrow.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2016-12-05 00:24:47 | Re: Hash tables in dynamic shared memory |
| Previous Message | Pavel Stehule | 2016-12-04 22:12:55 | Re: patch: function xmltable |