From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> |
Subject: | Re: [patch] Proposal for \crosstabview in psql |
Date: | 2016-03-20 21:27:44 |
Message-ID: | CAFj8pRAYgw2a0YqAZ5FRiqCz1D3=p=7XBt_SHJojzbR3jHeG2g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
2016-03-19 16:31 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
> Pavel Stehule wrote:
>
> > Can I do review?
>
> Of course.
>
I did review of last patch. I had to do small changes to run the code due
last Tom's changes in psql. Updated patch is attached.
The last changes in this patch are two:
1. Remove strange server side sorting
2. Cleaning/reducing interface
Other code is +/- without changes. There was lot of discussion in this
thread, I would not to repeat it.
I'll comment the changes:
@1 using server side sorting was really generic, but strange. Now, the
crosstabview works without it without any significant functionality
degradation.
@2 interface is minimalist - but good enough - I am thinking so it is good
start point. I was able to run my examples without problems. The previous
API was more comfortable - "+","-" symbols allows to specify order quickly,
but without a agreement we can live without this feature. Now, a order of
data is controlled fully by SQL. crosstabview does data visualization only.
I have not any objection to this last design. It is reduced to minimum, but
still it works well.
* All regress tests passed
* A code is well and well commented
* No new warnings or compilation issues
* Documentation is clean
I have two minor notes, can be fixed simply, if we accept this last design:
1. can be nice if documentation will contains one example
2. some regress tests
From my perspective, it is ready for commiter. Daniel solved the most big
issues.
Regards
Pavel
> --
> Álvaro Herrera http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
Attachment | Content-Type | Size |
---|---|---|
psql-crosstabview-v13.diff | text/plain | 39.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2016-03-20 21:46:12 | Re: Performance degradation in commit ac1d794 |
Previous Message | Tomas Vondra | 2016-03-20 20:47:14 | Re: Parallel Aggregate |