Re: proposal: psql command \graw

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: psql command \graw
Date: 2017-11-10 06:21:14
Message-ID: CAFj8pRAOAXZfCmFtgZ+Fb9goc-AkMhNU1DjeN59v=VB9bnwu6A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

2017-11-09 21:12 GMT+01:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:

>
>
> 2017-11-09 21:03 GMT+01:00 Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>:
>
>>
>> Hello Pavel,
>>
>> I hope so I fixed all mentioned issues.
>>>
>>
>> Patch applies with a warning:
>>
>> > git apply ~/psql-graw-2.patch
>> /home/fabien/psql-graw-2.patch:192: new blank line at EOF.
>> +
>> warning: 1 line adds whitespace errors.
>>
>> Otherwise it compiles. "make check" ok. doc gen ok.
>>
>> Two spurious empty lines are added before StoreQueryTuple.
>>
>> Doc: "If <literal>+</literal> is appended to the command name, a column
>> names are displayed."
>>
>> I suggest instead: "When <literal>+</literal> is appended, column names
>> are also displayed."
>>
>> ISTM that you can remove "force_column_header" and just set "tuple_only"
>> to what you need, that is you do not need to change anything in function
>> "print_unaligned_text".
>>
>
> Last point is not possible - I would not to break original tuple only
> mode.
>
>
updated patch

> Pavel
>
>>
>> --
>> Fabien.
>>
>
>

Attachment Content-Type Size
psql-graw-3.patch text/x-patch 7.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2017-11-10 07:07:01 Re: path toward faster partition pruning
Previous Message Kyotaro HORIGUCHI 2017-11-10 05:44:55 Re: path toward faster partition pruning