Re: proposal: plpgsql - Assert statement

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: plpgsql - Assert statement
Date: 2014-11-19 22:15:19
Message-ID: CAFj8pRAFj7_urG7EO4+8+=kCZkSKKgnA3cgHqdpYnYLyX7A7dA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2014-11-19 17:13 GMT+01:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:

> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > On 11/19/2014 06:35 AM, Simon Riggs wrote:
> >> I seem to share the same opinion with Andrew: its not going to hurt to
> >> include this, but its not gonna cause dancing in the streets either. I
> >> would characterize that as 2 very neutral and unimpressed people, plus
> >> 3 in favour. Which seems enough to commit.
>
> > That's about right, although I would put it a bit stronger than that.
> > But if we're the only people unimpressed I'm not going to object further.
>
> FWIW, I would vote against it also. I do not find this to be a natural
> extension of RAISE; it adds all sorts of semantic issues. (In particular,
> what is the evaluation order of the WHEN versus the other subexpressions
> of the RAISE?)
>

last query looks clean for me. First we evaluate WHEN expression, next (if
previous expression is true) we evaluate a expressions inside RAISE
statement.

Regards

Pavel

>
> regards, tom lane
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2014-11-19 22:16:35 Re: proposal: plpgsql - Assert statement
Previous Message Peter Geoghegan 2014-11-19 22:09:45 amcheck prototype