| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql - factor out echo code |
| Date: | 2022-12-01 07:27:46 |
| Message-ID: | CAFj8pRA4jk--M1165fy1_3Z1A8471dyWTfQ-Uy9uAsgM2x35Kw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
st 30. 11. 2022 v 10:43 odesílatel Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
napsal:
>
> >> Now some of the output generated by test_extdepend gets a bit
> >> confusing:
> >> +-- QUERY:
> >> +
> >> +
> >> +-- QUERY:
> >>
> >> That's not entirely this patch's fault. Still that's not really
> >> intuitive to see the output of a query that's just a blank spot..
> >
> > Hmmm.
> >
> > What about adding an explicit \echo before these empty outputs to
> mitigate
> > the possible induced confusion?
>
> \echo is not possible.
>
> Attached an attempt to improve the situation by replacing empty lines with
> comments in this test.
>
I can confirm so all regress tests passed
Regards
Pavel
>
> --
> Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-12-01 07:42:19 | Re: [PATCH] Add native windows on arm64 support |
| Previous Message | John Naylor | 2022-12-01 07:06:26 | Re: [PoC] Improve dead tuple storage for lazy vacuum |