Re: citext function overloads for text parameters

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Shay Rojansky <roji(at)roji(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: citext function overloads for text parameters
Date: 2018-05-06 13:07:35
Message-ID: CAFj8pRA4cDW3hZOLJP_=XMEcH06CNHRWv8DeDONv_Bv0ZVojnw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2018-05-06 14:55 GMT+02:00 Shay Rojansky <roji(at)roji(dot)org>:

> Thanks for your answer Pavel.
>
> This is expected - it is side effect of PostgreSQL implementation of
>> function overloading and type conversions
>>
>> after installation citext, you will have more instances of function strpos
>>
>> strpos(citext, citext)
>> strpos(text, text)
>>
>
> Do you think it would be appropriate to simply add an strpos(citext, text)
> overload to the extension to make sure this behaves more as expected? If so
> I can try to submit a patch at some point.
>

It has sense in this case. But I have not a idea if there can be some more
broken.

regards

Pavel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-05-06 13:34:52 perlcritic and perltidy
Previous Message Shay Rojansky 2018-05-06 12:55:24 Re: citext function overloads for text parameters