Re: patch: function xmltable

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: function xmltable
Date: 2016-12-07 13:47:50
Message-ID: CAFj8pRA3nUwTM=ZSeznS=0pdYoeZ9pj-CsbK-TcLrVR-3bjahw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

2016-12-07 8:14 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:

> Here's v21.
>
> * I changed the grammar by moving the NOT NULL to the column options,
> and removing the IsNotNull production. It wasn't nice that "NOT NULL
> DEFAULT 0" was not accepted, which it is with the new representation.
>
> * The tuple that's returned is natively a TupleTableSlot inside the
> table builder, not directly a HeapTuple. That stuff was ugly and wasn't
> using the proper abstraction anyway.
>
> * I changed the signatures of the methods so that they receive
> TableExprState, and restructured the "opaque" data to be inside
> TableExprState. Now we don't need to have things such as the tupdesc or
> the input functions be repeated in the opaque struct. Instead they
> belong to the TableExprState and the methods can read them from there.
>
> I managed to break the case with no COLUMNS. Probably related to the
> tupdesc changes. It now crashes the regression test. Too tired to
> debug now; care to take a look? The other stuff seems to run fine,
> though of course the regression test crashes in the middle, so perhaps
> there are other problems.
>

I fixed two issues.

1. there are not columns data when there are not any explicit column - fixed

2. there was reverse setting in NOT NULL flag

all tests passed now

Regards

Pavel

> --
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>

Attachment Content-Type Size
xmltable-22.patch text/x-patch 166.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei KaiGai 2016-12-07 13:50:22 varlena beyond 1GB and matrix
Previous Message Aleksander Alekseev 2016-12-07 13:47:34 Re: [PATCH] PostgresNode.pm enhancements, pg_lsn helper, and some more recovery tests