|From:||Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>|
|To:||PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Cc:||Craig Ringer <craig(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>|
|Subject:||Re: [PATCH] PostgresNode.pm enhancements, pg_lsn helper, and some more recovery tests|
|Views:||Raw Message | Whole Thread | Download mbox|
I noticed that these patches have a "Needs review" status and decided to
take a look. Surprisingly I didn't manage to find many defects.
* I like this idea in general;
* Code is test covered and documented well;
* All tests pass;
* No warnings during compilation and/or tests run;
* I didn't find any typos;
* Code style seems to be OK;
Though are you sure you want to name a class like_this instead of LikeThis?
It's quite uncommon in Perl code and usually used only for packages like
"strict" and "warnings". However I prefer no to insist on changes like
this since it's a matter of taste.
The bottom line --- this code looks good to me. If there is nothing you
would like to change in the last moment I suggest to change the status
to "Ready for committer".
|Next Message||Pavel Stehule||2016-12-07 13:47:50||Re: patch: function xmltable|
|Previous Message||Michael Paquier||2016-12-07 12:50:12||Re: Test "tablespace" fails during `make installcheck` on master-replica setup|