Re: JsonbValue to Jsonb conversion

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: JsonbValue to Jsonb conversion
Date: 2014-10-13 14:54:02
Message-ID: CAFj8pRA-o2AaVF5maqquadY6cszFwDKzmA2tU_=ZTPLJTST18A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2014-10-13 15:45 GMT+02:00 Andrew Dunstan <andrew(at)dunslane(dot)net>:

>
> On 10/13/2014 06:41 AM, Pavel Stehule wrote:
>
>> Hi
>>
>> I am working on review of this patch.
>>
>
>
> The patch attached to the message you are replying to was never intended
> to be reviewed. It was only given by way of illustration of a technique.
>
> The original patch to be reviewed is on the message <
> http://www.postgresql.org/message-id/5425D277.4030804@dunslane.net> as
> shown on the commitfest app. I have just submitted a revised patch to fix
> the compiler warnings you complained of, at <http://www.postgresql.org/
> message-id/543BD598(dot)4020809(at)dunslane(dot)net> I have not found any segfaults
> in the regression tests.
>
> And please don't top-post on the PostgreSQL lists.
>

Attached small fix of uninitialized local variable

Regards

Pavel

>
> cheers
>
> andrew
>
>
>

Attachment Content-Type Size
jsonbmissingfuncs3-2.patch text/x-patch 60.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-10-13 14:55:16 Re: [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...
Previous Message Sean Chittenden 2014-10-13 14:49:44 Re: [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...