Re: Fix slot synchronization with two_phase decoding enabled

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix slot synchronization with two_phase decoding enabled
Date: 2025-06-05 09:23:21
Message-ID: CAFiTN-vxo1Wz_ipwZ3R+Fm3DsVkXgBp-vMJCJp3w+0S_pm6C1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 3, 2025 at 11:05 AM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
>
> Attached v17 patches. Added a top-up patch 0002 implementing the idea
> suggested by Amit above.

I have started reviewing this, although I haven't done a complete
review yet, but I have a question on the fix we are trying to do, IIUC
we are disallowing to use 'two phase' and 'failover' options together
at the create slot time and now users has to create slot with one of
the option and later enable other option right (if user want to use
both options)? But don't you think it will affect usability? because
if a user wants to use both the options together then after creating
the slot they need to track when is the right time to enable the other
option? Not sure if anyone else has this concern or it's just me?

--
Regards,
Dilip Kumar
Google

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrice Chapuis 2025-06-05 09:40:31 Re: synchronized_standby_slots used in logical replication
Previous Message Peter Eisentraut 2025-06-05 09:15:55 Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths