| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal : Parallel Merge Join |
| Date: | 2017-02-25 09:52:12 |
| Message-ID: | CAFiTN-vw52OefRPDnDf064q-N9bCBjPPxAS2SxiP18DG2Daiww@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Feb 25, 2017 at 11:29 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> It seems you have forgotten to change in the below check:
>
> + if (innerpath != NULL &&
> + innerpath->parallel_safe &&
> + (cheapest_startup_inner == NULL ||
> + cheapest_startup_inner->parallel_safe == false ||
> + compare_path_costs(innerpath, cheapest_startup_inner,
> + STARTUP_COST) < 0))
Oops, Fixed.
>
>
> + /* Found a cheap (or even-cheaper) sorted parallel safer path */
>
> typo
> /safer/safe
Fixed
>
> Note - Change the patch status in CF app (to Needs Review) whenever
> you post a new patch. I could see that your other patch also needs a
> similar update in CF app.
Will changes, Thanks.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| parallel_mergejoin_v7.patch | application/octet-stream | 15.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2017-02-25 11:36:20 | Re: Allow pg_dumpall to work without pg_authid |
| Previous Message | Erik Rijkers | 2017-02-25 08:40:45 | Re: Logical replication existing data copy |