| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-10-12 10:09:21 |
| Message-ID: | CAFiTN-vr0r1RsQ46HC3LY3D_sdR5_s1Sbz5EN3vyh4LKRTrLVA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Oct 11, 2026 at 11:12 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Sun, Oct 11, 2026 at 2:37 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > Okay that makes sense. Here is the updated version of the patch
> > changes compared to previous version
> >
>
> Thanks for the new version. We can combine 0001 and 0002 now but most
> importantly you seem to forget including the code optimizations
> suggested by Hou-San and me in emails [1][2].
>
> [1] - https://www.postgresql.org/message-id/CAFvd2n92EXzt7VNRGxQCMkK1t2%2B6RA9SwQ5j9DHMwJcWCNoK1Q%40mail.gmail.com
> [2] - https://www.postgresql.org/message-id/CAA4eK1L-yBio2zbSVsKQ9LCy8orszXviqORHp%3Dsg2jSq%3D76D2A%40mail.gmail.com
>
Okay, I missed them, I think both of these optimizations make sense,
especially hinding the complexity of decision on conflict log
destination inside get_conflictlog_dest_and_table() simplify the code
to a great extent. So I will include them in the next version and
will also merge 0001 and 0002
--
Regards,
Dilip Kumar
Google
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Burd | 2026-10-12 10:33:24 | Re: Adding basic NUMA awareness |
| Previous Message | Daniel Gustafsson | 2026-10-12 10:07:05 | Re: [PATCH v1] Doc: use double quotes for ulink URLs in features.sgml |