Re: BUG #18961: Race scenario where max_standby_streaming_delay is not honored

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Anthony Hsu <erwaman(at)gmail(dot)com>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18961: Race scenario where max_standby_streaming_delay is not honored
Date: 2025-06-30 03:28:33
Message-ID: CAFiTN-voadWSLkN2XGOPNsiYLJ-=hNvUDtEM8aefBq=PL25QPw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sun, Jun 29, 2025 at 5:07 AM Anthony Hsu <erwaman(at)gmail(dot)com> wrote:
>
> Made a few changes to my patch and attached a new version. Changes include:
>
> * avoid sending PROCSIG_RECOVERY_CONFLICT_BUFFERPIN in a tight loop after standby limit is reached by adding a small sleep after each send, starting at 1ms and doubling each time up to 1s (similar to what's done in WaitExceedsMaxStandbyDelay here [1]). Sleep time is reset in LockBufferForCleanup once cleanup lock is successfully acquired
> * don't set deadlock timeout once standby limit has passed since after that, the standby timeout will fire immediately, so no need to set deadlock timeout as well
>
> Let me know if you have any thoughts or comments. I am thinking of sending it to pgsql-hackers soon.

I haven't got time to look into your new patch, feel free to start a
thread in pgsql-hackers, I can review it there once I get time,
thanks.

--
Regards,
Dilip Kumar
Google

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Masahiko Sawada 2025-06-30 03:40:37 Re: Logical replication 'ERROR: invalid memory alloc request size 1831213792' after upgrading to 15.13
Previous Message Tom Lane 2025-06-30 02:23:30 Re: BUG #18970: Atempt to alter type of table column used in row type with check leads to assertion failure