Re: BUG #19074: pg_dump from v18 loses the NOT NULL flag in the inherited table field when dumping v17-databases

On Mon, Oct 6, 2025 at 9:29 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Mon, 6 Oct 2025 at 16:42, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > I tried to reproduce this, but here is what I see[1] when I dump in
> > REL_18_STABLE, I noticed that "NOT NULL a" for inherited tables is
> > included along with the create table statement itself, so this doesn't
> > seems like an issue, am I missing something?
>
> I think so. I believe the intent was to convey the server version is
> 17.6 and the pg_dump version is 18.0, in which case, there does appear
> to be a problem.
>

Yeah you are right, while checking the git log, it seems it got broken
in this commit [1]. So I just tested on the previous commit and it
was working fine but got broken on this commit. Adding Alvaro as he
has committed this.

[1]
commit 14e87ffa5c543b5f30ead7413084c25f7735039f
Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Date: Fri Nov 8 13:28:48 2024 +0100
Add pg_constraint rows for not-null constraints

--
Regards,
Dilip Kumar
Google