Re: SUBTRANS: Minimizing calls to SubTransSetParent()

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SUBTRANS: Minimizing calls to SubTransSetParent()
Date: 2022-08-11 05:31:51
Message-ID: CAFiTN-vONGDL8vEMnv2SzL0zgOs2uti7uZGX-VMP_5tvWv1JqA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 10, 2022 at 6:31 PM Simon Riggs
<simon(dot)riggs(at)enterprisedb(dot)com> wrote:
>
> On Wed, 10 Aug 2022 at 08:34, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > Am I still missing something?
>
> No, you have found a dependency between the patches that I was unaware
> of. So there is no bug if you apply both patches.

Right

>
> > So I still think some adjustment is required in XidInMVCCSnapdhot()
>
> That is one way to resolve the issue, but not the only one. I can also
> change AssignTransactionId() to recursively register parent xids for
> all of a subxid's parents.
>
> I will add in a test case and resolve the dependency in my next patch.

Okay, thanks, I will look into the updated patch after you submit that.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2022-08-11 05:35:30 Re: use SSE2 for is_valid_ascii
Previous Message Dilip Kumar 2022-08-11 05:28:42 Re: making relfilenodes 56 bits