| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Rintaro(dot)Ikeda(at)nttdata(dot)com |
| Cc: | ikedarintarof(at)oss(dot)nttdata(dot)com, slpmcf(at)gmail(dot)com, boekewurm+postgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org, Nobuyuki12(dot)Tanaka(at)nttdata(dot)com |
| Subject: | Re: Suggestion to add --continue-client-on-abort option to pgbench |
| Date: | 2025-05-13 05:56:52 |
| Message-ID: | CAFiTN-v6biSNm0uUDDEMSD=DTcWXhbA7KonjAGOhtYLWg8o7Og@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 13, 2025 at 9:20 AM <Rintaro(dot)Ikeda(at)nttdata(dot)com> wrote:
> I also appreciate you for pointing out my mistakes in the previous version of the patch. I fixed the duplicated lines. I’ve attached the updated patch.
>
This is a useful feature, so +1 from my side. Here are some initial
comments on the patch while having a quick look.
1. You need to update the stats for this new counter in the
"accumStats()" function.
2. IMHO, " continue-on-error " is more user-friendly than
"continue-client-on-error".
3. There are a lot of whitespace errors, so those can be fixed. You
can just try to apply using git am, and it will report those
whitespace warnings. And for fixing, you can just use
"--whitespace=fix" along with git am.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2025-05-13 06:05:24 | Re: PG 18 release notes draft committed |
| Previous Message | Yasir | 2025-05-13 05:28:51 | Re: Why our Valgrind reports suck |