From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
---|---|
To: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Is Recovery actually paused? |
Date: | 2021-01-27 08:58:22 |
Message-ID: | CAFiTN-v-xmzhpfNvB+U5iO1UQ202oxGhTUrEhmyo_ezwZ4KnUQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 27, 2021 at 2:06 PM Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
>
> On Wed, 27 Jan 2021 13:29:23 +0530
> Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> > On Wed, Jan 27, 2021 at 12:50 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> > > On Tue, Jan 26, 2021 at 2:00 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > > >
> > > > On Sat, Jan 23, 2021 at 6:10 AM Bharath Rupireddy
> > > > <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> > > > > +1 to just show the recovery pause state in the output of
> > > > > pg_is_wal_replay_paused. But, should the function name
> > > > > "pg_is_wal_replay_paused" be something like
> > > > > "pg_get_wal_replay_pause_state" or some other? To me, when "is" exists
> > > > > in a function, I expect a boolean output. Others may have better
> > > > > thoughts.
> > > >
> > > > Maybe we should leave the existing function pg_is_wal_replay_paused()
> > > > alone and add a new one with the name you suggest that returns text.
> > > > That would create less burden for tool authors.
> > >
> > > +1
> > >
> >
> > Yeah, we can do that, I will send an updated patch soon.
>
> This means pg_is_wal_replay_paused is left without any change and this
> returns whether pause is requested or not? If so, it seems good to modify
> the documentation of this function in order to note that this could not
> return the actual pause state.
Yes, we can say that it will return true if the replay pause is
requested. I am changing that in my new patch.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2021-01-27 08:59:58 | Re: Support ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION ... syntax |
Previous Message | Paul Guo | 2021-01-27 08:36:22 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |