From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
---|---|
To: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
Cc: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [BUG]Update Toast data failure in logical replication |
Date: | 2021-06-02 13:53:16 |
Message-ID: | CAFiTN-v-VvDBOmK-RUp8=+fLuGS8BVjtvzUYj9Fq7A8cjYJjnA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 2, 2021 at 7:20 PM Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> wrote:
>
> On Wed, Jun 2, 2021 at 3:10 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > Yes, you are right. I will change it in the next version, along with
> > the test case.
> >
> + /*
> + * if the key hasn't changed and we're only logging the key, we're done.
> + * But if tuple has external data then we might have to detoast the key.
> + */
> This doesn't really mention why we need to detoast the key even when
> the key remains the same. I guess we can add some more details here.
Noted, let's see what others have to say about fixing this, then I
will fix this along with one other pending comment and I will also add
the test case. Thanks for looking into this.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-06-02 13:58:00 | Re: Support for CREATE MODULE? |
Previous Message | Kuntal Ghosh | 2021-06-02 13:50:35 | Re: [BUG]Update Toast data failure in logical replication |