Re: making relfilenodes 56 bits

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re: making relfilenodes 56 bits
Date: 2022-07-28 11:31:47
Message-ID: CAFiTN-uwSER21k_-WehsHe63fJTY+Bizc+Q+6S58xp4YvsJV_Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 27, 2022 at 11:39 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Wed, Jul 27, 2022 at 12:37 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > Just realised that this should have been BufferTagsEqual instead of BufferTagEqual
> >
> > I will modify this and send an updated patch tomorrow.
>
> I changed it and committed.
>
> What was formerly 0002 will need minor rebasing.

Thanks, I have rebased other patches, actually, there is a new 0001
patch now. It seems during renaming relnode related Oid to
RelFileNumber, some of the references were missed and in the last
patch set I kept it as part of main patch 0003, but I think it's
better to keep it separate. So took out those changes and created
0001, but you think this can be committed as part of 0003 only then
also it's fine with me.

I have done some cleanup in 0002 as well, basically, earlier we were
storing the result of the BufTagGetRelFileLocator() in a separate
variable which is not required everywhere. So wherever possible I
have avoided using the intermediate variable.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v14-0002-Preliminary-refactoring-for-supporting-larger-re.patch text/x-patch 21.7 KB
v14-0001-Fixup-Oid-to-RelfileNumber.patch text/x-patch 9.5 KB
v14-0003-Widen-relfilenumber-from-32-bits-to-56-bits.patch text/x-patch 98.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2022-07-28 11:46:01 Re: [Commitfest 2022-07] Patch Triage: Waiting on Author
Previous Message vignesh C 2022-07-28 10:45:42 Re: Handle infinite recursion in logical replication setup