| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: making relfilenodes 56 bits |
| Date: | 2022-07-28 14:29:16 |
| Message-ID: | CA+TgmoZ1HAQxAXQb_guUB+Tsdaat54rtisf9qD0diWxcUgd3nA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 28, 2022 at 7:32 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> Thanks, I have rebased other patches, actually, there is a new 0001
> patch now. It seems during renaming relnode related Oid to
> RelFileNumber, some of the references were missed and in the last
> patch set I kept it as part of main patch 0003, but I think it's
> better to keep it separate. So took out those changes and created
> 0001, but you think this can be committed as part of 0003 only then
> also it's fine with me.
I committed this in part. I took out the introduction of
RELNUMBERCHARS as I think that should probably be a separate commit,
but added in a comment change that you seem to have overlooked.
> I have done some cleanup in 0002 as well, basically, earlier we were
> storing the result of the BufTagGetRelFileLocator() in a separate
> variable which is not required everywhere. So wherever possible I
> have avoided using the intermediate variable.
I'll have a look at this next.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-07-28 14:33:08 | Re: replacing role-level NOINHERIT with a grant-level option |
| Previous Message | Tom Lane | 2022-07-28 14:28:04 | Re: small windows psqlrc re-wording |