Re: [PATCH] Add RetrieveInstrumentation hook for CustomScan providers

On Thu, Jul 9, 2026 at 1:37 PM Siddharth Kothari <sidkot(at)google(dot)com> wrote:
>
> Hi Tomas,
>
> Thanks for the review, and no worries.
> I completely agree with both of your suggestions.
>
> I added the new missing callbacks:
>
> ExecCustomScanInstrumentEstimate
> ExecCustomScanInstrumentInitDSM
> ExecCustomScanInstrumentInitWorker
> along with the existing
> ExecCustomScanRetrieveInstrumentation
>
> and extracted the custom scan instrumentation tracking out of the
> parallel_aware guard block in execParallel.c. The core execution
> orchestrator will now correctly invoke these instrumentation callbacks
> even when a CustomScan node is part of a parallel chunk but not
> strictly parallel_aware itself.
>
> I also updated the Custom scan documentation to properly document the
> new callbacks.
>
> I've attached the v3 patch with these changes included. Let me know if
> everything looks good or if there is anything else I should adjust.

I think the idea looks fine, and the patch looks good to me.

One suggestion, not on the patch itself, but while responding on
pgsql-hackers: avoid top-posting your replies. You can check out the
community etiquette guidelines here:
https://wiki.postgresql.org/wiki/Mailing_Lists

--
Regards,
Dilip Kumar
Google