| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Relation extension scalability |
| Date: | 2016-01-25 06:30:56 |
| Message-ID: | CAFiTN-uUpJpvc=VkioX3ew3-OzCfhSdsB8e0Y94XpOYUy0PBpQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 23, 2016 at 4:28 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
> I found one more problem with patch.
>
> ! UnlockReleaseBuffer(buffer);
> ! RecordPageWithFreeSpace(relation, BufferGetBlockNumber(buffer),
> freespace);
>
> You can't call BufferGetBlockNumber(buffer) after releasing
> the pin on buffer which will be released by
> UnlockReleaseBuffer(). Get the block number before unlocking
> the buffer.
>
Good catch, will fix this also in next version.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2016-01-25 06:39:02 | Re: Add generate_series(date, date) and generate_series(date, date, integer) |
| Previous Message | Dilip Kumar | 2016-01-25 06:29:46 | Re: Relation extension scalability |