| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-06-27 02:37:51 |
| Message-ID: | CAFiTN-uS7TggxpsFvWsH0Ugb5oz8TgB4yNUzvVSiaFn=n9t6bg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 25, 2026 at 8:01 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> On Wed, Jun 24, 2026 at 7:26 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > Please find the updated patch set attached.
>
> Hi Dilip,
>
> I ran a code coverage report on v56-0001 and v56-0002 and found a few
> cases not covered by existing tests. I added tests for the following:
>
> 1) check_publication_add_relation() – verify that adding a conflict
> table to a publication errors out
> 2) execMain.c: CheckValidRowMarkRel() – verify row locking on CLT is
> rejected for commands like SELECT ... FOR UPDATE
> 3) The test scenario shared by Shveta at [1]
>
> Please consider the patch if you are okay with it. The patch applies
> cleanly on top of latest v58-0002 patch,
>
> [1] https://www.postgresql.org/message-id/CAJpy0uC5x%2BZ%3Dfvurvz%3DK8EYQSCQ1SCouR2LqiHS27Hp_Tzi6qw%40mail.gmail.com
Thanks Nisha. I have merged your changes.
--
Regards,
Dilip Kumar
Google
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-06-27 02:44:07 | Re: [PATCH] Avoid collation lookup for "char" statistics |
| Previous Message | Dilip Kumar | 2026-06-27 02:36:30 | Re: Proposal: Conflict log history table for Logical Replication |