| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, "shveta(dot)malik(at)gmail(dot)com" <shveta(dot)malik(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Include schema-qualified names in publication error messages. |
| Date: | 2026-04-30 13:53:36 |
| Message-ID: | CAFiTN-uF3X5TQPEUdz5oA3BnK7two36YJdBmkvow2zQCaSyYJA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 30 Apr 2026 at 7:14 PM, Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
>
> On Thu, Apr 30, 2026, at 4:37 AM, Dilip Kumar wrote:
> >
> > Yeah we may, but I feel what we have now looks more readable.
> >
>
> My suggestion is that this function should be available in a central place.
> That's not the only place that could use qualified schema and relation. If
> you
> search for get_namespace_name_or_temp you will notice that this code path
> is
> repeated in other parts of the code too (see ruleutils.c). It would be
> good if
> we can have a common path for it. Maybe the signature has to be
> get_qualified_relname(Oid) to accommodate
IMHO it’s not a good idea to use Oid when you already have reldesc.
—
Dilip
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hannu Krosing | 2026-04-30 14:02:56 | Re: Support logical replication of DDLs, take2 |
| Previous Message | Euler Taveira | 2026-04-30 13:44:35 | Re: Include schema-qualified names in publication error messages. |