Re: [HACKERS] Custom compression methods

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [HACKERS] Custom compression methods
Date: 2021-03-12 05:54:57
Message-ID: CAFiTN-uEUcz7-hp6ytG5BfXi7JeHPSozj9N1nqYL7nXjbGpo_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 12, 2021 at 10:45 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> On Thu, Mar 11, 2021 at 12:25:26PM -0600, Justin Pryzby wrote:
> > On Wed, Mar 10, 2021 at 08:28:58PM -0600, Justin Pryzby wrote:
> > > This includes a patch to use pkgconfig, in an attempt to build on mac, which
> > > currently fails like:
> > >
> > > https://cirrus-ci.com/task/5993712963551232?command=build#L126
> > > checking for LZ4_compress in -llz4... no
> > > configure: error: library 'lz4' is required for LZ4 support
> >
> > This includes a 2nd attempt to use pkg-config to build on mac.
> >
> > If this doesn't work, we should ask for help from a mac user who wants to take
> > on a hopefully-quick project.
>
> The 2nd attempt passed ./configure on mac (and BSD after Thomas installed
> pkg-config), but I eventually realized that LZ4 was effectively disabled,
> because we set HAVE_LZ4, but the code tested instead WITH_LIBLZ4.

So is it working on the Mac with your latest changes in 0005 or we
need to wait for the result? Also is there any reason for changing
HAVE_LIBLZ4 to USE_LZ4?

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2021-03-12 05:55:46 Re: [PATCH] Hooks at XactCommand level
Previous Message tsunakawa.takay@fujitsu.com 2021-03-12 05:54:29 RE: [POC] Fast COPY FROM command for the table with foreign partitions