Re: A recent message added to pg_upgade

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, smithpb2250(at)gmail(dot)com, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: A recent message added to pg_upgade
Date: 2025-07-09 12:16:32
Message-ID: CAFiTN-u78H=Eict3oVDyoNmB6F4usYv-xYd4b11Hp6EL-kQO5w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 9, 2025 at 5:29 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Jul-09, Dilip Kumar wrote:
>
> > On Wed, Jul 9, 2025 at 9:07 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> > > After further consideration, I believe your proposed method is
> > > superior to forcing the max_slot_wal_keep_size to -1 via a check hook.
> > > The ultimate goal is to prevent WAL removal during a binary upgrade,
> > > and your approach directly addresses this issue rather than
> > > controlling it by forcing the GUC value. I am planning to send a
> > > patch using this approach for both max_slot_wal_keep_size as well as
> > > for idle_replication_slot_timeout.
> >
> > PFA, with this approach.
>
> This indeed makes the whole thing a lot simpler and more direct than the
> original code, and solves this subthread's complaint. It's a bit weird
> that slot.c and xlog.c now have to worry about IsBinaryUpgrade, but I
> don't feel any guilt about that.

Thanks Alvaro for having a look.

> I propose a few comment updates on top of your patch.

This comment updates LGTM, so included in v3.

--
Regards,
Dilip Kumar
Google

Attachment Content-Type Size
v3-0001-Better-way-to-prevent-wal-removal-and-slot-invali.patch application/octet-stream 7.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-07-09 12:27:35 Re: ABI Compliance Checker GSoC Project
Previous Message Dean Rasheed 2025-07-09 12:13:57 Re: Allow ON CONFLICT DO UPDATE to return EXCLUDED values