| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Cc: | Maxim Boguk <maxim(dot)boguk(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed. |
| Date: | 2016-11-07 15:12:19 |
| Message-ID: | CAFiTN-tS2d6d_Fku9KYcoz3PMg7Mdp_KXx4vxCN_YAG3xSVweA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Fri, Nov 4, 2016 at 7:14 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:
>> + if (cstate->rel->rd_rel->relkind != RELKIND_RELATION
>> + && (!cstate->rel->trigdesc ||
>> + !cstate->rel->trigdesc->trig_insert_instead_row))
>
>
> changed.
>
>>
>> Meanwhile I will test it and give the feedback.
>
>
> Thanks.
>
> Updated patch is attached with added regression tests.
I have done with review and test, patch looks fine to me.
moved to "Ready for Committer"
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jdnelson | 2016-11-07 18:27:07 | BUG #14416: checkpoints never completed |
| Previous Message | Tom Lane | 2016-11-07 15:05:30 | Re: BUG #14415: non-breaking space matching in regex as whitespace |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2016-11-07 15:12:39 | Re: Specifying the log file name of pgbench -l option |
| Previous Message | Peter Eisentraut | 2016-11-07 15:08:24 | Re: [COMMITTERS] pgsql: pg_xlogdump: Add NLS |