Re: Fastpath while arranging the changes in LSN order in logical decoding

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fastpath while arranging the changes in LSN order in logical decoding
Date: 2020-03-24 13:06:03
Message-ID: CAFiTN-sp701wvzvnLQJGk7JDqrFM8f--97-ihbwkU8qvn=p8nw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 24, 2020 at 6:16 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Mar 9, 2020 at 11:07 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >
> > On 2020-03-07 11:15:27 +0530, Dilip Kumar wrote:
> > > IMHO, if we conclude that because there is no performance gain so we
> > > don't want to add one extra path in the code then we might want to
> > > remove that TODO from the code so that we don't spend time for
> > > optimizing this in the future.
> >
> > +1
> >
>
> Dilip, are you planning to do more tests for this? Anyone else wants
> to do more tests? If not, based on current results, we can remove that
> TODO and in future, if someone comes with a test case to show benefit
> for adding fastpath, then we can consider the patch proposed by Dilip.

IMHO, I have tried the best case but did not see any performance gain
so I am not planning to test this further. I have attached the patch
for removing the TODO.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-Remove-TODO-comments-for-fast-path.patch application/octet-stream 1.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2020-03-24 13:20:07 Re: Additional improvements to extended statistics
Previous Message Masahiko Sawada 2020-03-24 12:47:30 Re: error context for vacuum to include block number