Re: [BUG]Missing REPLICA IDENTITY check when DROP NOT NULL

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Subject: Re: [BUG]Missing REPLICA IDENTITY check when DROP NOT NULL
Date: 2021-11-25 05:14:53
Message-ID: CAFiTN-soXRL2T3Rj12dPFR-bza+m4ubSmsWmMfeprVPaNGHH1Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 25, 2021 at 8:21 AM tanghy(dot)fnst(at)fujitsu(dot)com
<tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Wed, Nov 24, 2021 7:29 PM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

>
> Thanks for your comment. I agree with you.
> I have fixed it and attached v2 patch.

Good catch, your patch looks fine to me and solves the reported problem.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-11-25 05:32:04 Re: pg_dump, pg_basebackup don't error out with wrong option for "--format"
Previous Message Bharath Rupireddy 2021-11-25 05:14:03 pg_dump, pg_basebackup don't error out with wrong option for "--format"