| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Assertion failure while streaming toasted data |
| Date: | 2021-05-26 12:40:00 |
| Message-ID: | CAFiTN-so856uatNrtSp3XR3gfsRA0RDfXEuP7w-twL+R8UN5GQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 26, 2021 at 5:28 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, May 26, 2021 at 1:47 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > On Wed, May 26, 2021 at 11:53 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > >
> > > On Wed, May 26, 2021 at 11:19 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > >
> >
> > >
> > > > I searched and didn't find any similar existing tests. Can we think of
> > > > any other way to test this code path? We already have one copy test in
> > > > toast.sql, isn't it possible to write a similar test here?
> > >
> > > I will check that and let you know.
> >
> > I have followed this approach to write the test.
> >
>
> The changes look good to me. I have made minor modifications in the
> comments, see attached. Let me know what do you think?
Your modification looks good to me. Thanks!
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-05-26 13:06:08 | Re: Fdw batch insert error out when set batch_size > 65535 |
| Previous Message | Amit Kapila | 2021-05-26 12:21:10 | Re: Parallel Inserts in CREATE TABLE AS |