| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Subject: | Re: Track statistics for streaming of in-progress transactions |
| Date: | 2020-10-22 06:21:57 |
| Message-ID: | CAFiTN-sieF+0wX04AZLH3QNkBPnbLH9qXdg8drYuFmo1e6RY2g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 14, 2020 at 9:09 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Commit 464824323e has added the support of the streaming of
> in-progress transactions into the built-in logical replication. The
> attached patch adds the statistics about transactions streamed to the
> decoding output plugin from ReorderBuffer.
I have reviewed the attached patch, I have one comment
+ int64 streamTxns; /* number of transactions streamed to the decoding
output plugin */
+ int64 streamCount; /* streaming invocation counter */
+ int64 streamBytes; /* amount of data streamed to subscriber */
I think instead of saying "amount of data streamed to subscriber" it
should be " amount of data streamed to the decoding output plugin"
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2020-10-22 06:27:34 | Re: [patch] Fix checksum verification in base backups for zero page headers |
| Previous Message | Kyotaro Horiguchi | 2020-10-22 06:14:32 | Re: [Patch] Optimize dropping of relation buffers using dlist |