Re: Identify missing publications from publisher while create/alter subscription.

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Japin Li <japinli(at)hotmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Identify missing publications from publisher while create/alter subscription.
Date: 2021-05-07 06:20:23
Message-ID: CAFiTN-sbNq-1pC4Ji8fjLgF0cR-5b4Jk1BL3UdGZSfccu9ShSg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 6, 2021 at 7:22 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>

Some comments:
1.
I don't see any change in pg_dump.c, don't we need to dump this option?

2.
+ /* Try to connect to the publisher. */
+ wrconn = walrcv_connect(sub->conninfo, true, sub->name, &err);
+ if (!wrconn)
+ ereport(ERROR,
+ (errmsg("could not connect to the publisher: %s", err)));

Instead of using global wrconn, I think you should use a local variable?

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tsunakawa.takay@fujitsu.com 2021-05-07 06:21:59 RE: [bug?] Missed parallel safety checks, and wrong parallel safety
Previous Message Japin Li 2021-05-07 06:02:53 Re: Identify missing publications from publisher while create/alter subscription.