Re: Logical replication CPU-bound with TRUNCATE/DROP/CREATE many tables

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Keisuke Kuroda <keisuke(dot)kuroda(dot)3862(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Logical replication CPU-bound with TRUNCATE/DROP/CREATE many tables
Date: 2020-10-15 07:31:49
Message-ID: CAFiTN-sb8NEj+QSZF7TqySBhJww-a6HkC4YPtGCgQB3WYcT4Cg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 15, 2020 at 12:38 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Oct 14, 2020 at 4:51 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > On Wed, Oct 14, 2020 at 4:12 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > >
> > > Thanks for the tests. The latest patch looks mostly good to me. I have
> > > made minor changes to the patch (a) changed the order where the new
> > > message is placed at one place to make it consistent with other
> > > places, (b) as discussed offlist, removed the extra increment to a
> > > local variable in ReorderBufferRestoreChange, (c) ran pgindent.
> > >
> > > See the attached and let me know what do you think?
> >
> > The changes look good to me.
> >
>
> Pushed!

Thanks!

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2020-10-15 07:38:24 Re: Use appendStringInfoString and appendPQExpBufferStr where possible
Previous Message Michael Paquier 2020-10-15 07:22:12 Possible memory leak in pgcrypto with EVP_MD_CTX