Re: CHECKPOINT unlogged data

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: CHECKPOINT unlogged data
Date: 2025-07-10 04:25:37
Message-ID: CAFiTN-sTO1qscO98DrAoBW9BBs4skWp39McnFcSZi3D25t6sPg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 10, 2025 at 9:31 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
>
>
> On 2025/07/10 4:26, Nathan Bossart wrote:
> > Here is what I have staged for commit, which I'm planning to do on Friday.
>
> Thanks for updating the patches!
>
> Regarding the 0005 patch:
>
> - COMPLETE_WITH("MODE");
> + COMPLETE_WITH("MODE, FLUSH_UNLOGGED");
>
> Shouldn't that be:
>
> COMPLETE_WITH("MODE", "FLUSH_UNLOGGED");
>
> IOW, the two options should be separate strings, so it needs
> double quotes around each.

I agree that it makes more sense to treat them as 2 separate strings.

--
Regards,
Dilip Kumar
Google

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-07-10 04:33:34 Re: Windows question: when is LC_MESSAGES defined?
Previous Message Fujii Masao 2025-07-10 04:23:47 Re: Extend ALTER DEFAULT PRIVILEGES for large objects