Re: logical streaming of xacts via test_decoding is broken

On Thu, 12 Nov 2020 at 11:37 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:

> On Thu, Nov 12, 2020 at 11:29 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com>
> wrote:
> >
> > On Thu, Nov 12, 2020 at 8:45 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> > >
> >
> > > Another thing I am thinking let's just not expose skip_empty_stream to
> > > the user and consider the behavior based on the value of
> > > skip_empty_xacts. Internally, in the code, we can still have different
> > > variables to distinguish between empty_xacts and empty_streams.
> >
> > Yeah, even I think in most of the cases it makes more sense to have
> > skip_empty_xacts and skip_empty_stream similar values. So better we
> > don't expose skip_empty_stream. I agree that we need to keep two
> > variables to track the empty stream and empty xacts.
> >
>
> So, let's try to do this way and if we see any problems then we can
> re-think.

Sounds good to me, I will send the updated patch.

> --
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com