| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-05-31 06:02:51 |
| Message-ID: | CAFiTN-sKqOUbd71PvCX0bB0PSt9zWez=X4pe0Edn_yboZLyU5A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 28, 2026 at 4:38 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, May 26, 2026 at 2:38 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > 2)
> > drop_subscription_dependencies():
> >
> > + conflictrelname = get_rel_name(subconflictlogrelid);
> >
> > We can actually have a sanity check that we got the CLT using the relid.
> > Assert(conflictrelname != NULL);
> >
>
> elog will suit this place better as this can't be a direct coding
> mistake. I see that at other places we used elog. See
> if (result == NULL)
> elog(ERROR, "cache lookup failed for index %u", indexId);
Yes it make sense to report elog, I will change this.
--
Regards,
Dilip Kumar
Google
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2026-05-31 06:12:54 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Shinya Kato | 2026-05-31 04:51:10 | Re: Use pg_current_xact_id() instead of deprecated txid_current() |