On Sun, Feb 6, 2022 at 1:07 PM Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> wrote:
>
> > In if (source != PGC_S_DEFAULT) we are overwriting newval with
> > conf->reset_val so I think we should free the newval or can we even
> > avoid guc_strdup in case of (source != PGC_S_DEFAULT)?
>
> I think we can not avoid guc_strdup in case of (source != PGC_S_DEFAULT)
> because function call_string_check_hook() contains "free(*newval);" in
> PG_CATCH-section.
> Probably we should free the newval in block
+1
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com