| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2025-10-17 10:27:05 |
| Message-ID: | CAFiTN-sC4yE_u7fa+UQS38JvhxN_VYSWTq2O_2bTRxxq=eW8FQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 16, 2025 at 4:53 PM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com>
wrote:
> On Thursday, October 16, 2025 5:59 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> >
>
While reading through the patch, I have 2 comments in 0002
1.
+ ereport(LOG,
+ errmsg("logical replication sequence synchronization for subscription
\"%s\" - batch #%d = %d attempted, %d succeeded, %d skipped, %d mismatched,
%d insufficient permission, %d missing, ",
+ MySubscription->name, (current_index / MAX_SEQUENCES_SYNC_PER_BATCH) +
1, batch_size,
+ batch_succeeded_count, batch_skipped_count, batch_mismatched_count,
batch_insuffperm_count,
+ batch_size - (batch_succeeded_count + batch_skipped_count +
batch_mismatched_count + batch_insuffperm_count)));
+
The log message is ending with ..." %d missing, " (a trailing comma and
space).
2.
Also IMHO instead of just saying "missing" we can say "missing on/from
publisher" so that it would be more clear.
--
Regards,
Dilip Kumar
Google
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2025-10-17 10:28:57 | Re: ci: Skip minfree file in the cores_backtrace.sh |
| Previous Message | Fujii Masao | 2025-10-17 10:23:22 | Re: pg_restore --no-policies should not restore policies' comment |