Re: [HACKERS] Custom compression methods

On Fri, Mar 12, 2021 at 2:12 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Fri, Mar 12, 2021 at 10:45 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> >
> > On Thu, Mar 11, 2021 at 12:25:26PM -0600, Justin Pryzby wrote:
> > > On Wed, Mar 10, 2021 at 08:28:58PM -0600, Justin Pryzby wrote:
> > > > This includes a patch to use pkgconfig, in an attempt to build on mac, which
> > > > currently fails like:
> > > >
> > > > https://cirrus-ci.com/task/5993712963551232?command=build#L126
> > > > checking for LZ4_compress in -llz4... no
> > > > configure: error: library 'lz4' is required for LZ4 support
> > >
> > > This includes a 2nd attempt to use pkg-config to build on mac.
> > >
> > > If this doesn't work, we should ask for help from a mac user who wants to take
> > > on a hopefully-quick project.
> >
> > The 2nd attempt passed ./configure on mac (and BSD after Thomas installed
> > pkg-config), but I eventually realized that LZ4 was effectively disabled,
> > because we set HAVE_LZ4, but the code tested instead WITH_LIBLZ4.
>
> With this patch, I see USE_LZ4 is never defined in my centos
> machine(even --with-lz4), however it was working fine without the 0005
> patch. I will have a look why it is behaving like this so I will not
> include these changes until I figure out what is going on.

Just realized I was still checking for HAVE_LIBLZ4 not USE_LZ4, sorry
for the noise its working fine. And thanks for making it work for
mac.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com