From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
---|---|
To: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Remove "FROM" in "DELETE FROM" when using tab-completion |
Date: | 2021-05-10 13:44:54 |
Message-ID: | CAFiTN-s1uOqL1N46c+bOLMv_ymeP5+V7kdkOwgE9tYhxQgqJ-Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, May 10, 2021 at 5:57 PM tanghy(dot)fnst(at)fujitsu(dot)com
<tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Monday, May 10, 2021 4:15 PM, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote
> >We should change all to DELETE FROM (apart from \help of course), and same for
> >INSERT, change to INSERT INTO everywhere it makes sense.
>
> Thanks for the reply. Your advice sounds reasonable to me.
> So I tried to change all "DELETE" to "DELETE FROM" and "INSERT" to "INSERT INTO" in the attached patch except
> the follow cases which I think is in accordance with what PG-Doc said.
> CREATE POLICY
> CREATE [ OR REPLACE ] RULE
> CREATE [ OR REPLACE ] TRIGGER
> ALTER DEFAULT PRIVILEGES
>
> After applying the patch, the tap-tests for psql is passed.
> Please be free to tell me anything insufficient you found in my fix. Thanks.
LGTM.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2021-05-10 13:45:56 | Re: Corrected documentation of data type for the logical replication message formats. |
Previous Message | Euler Taveira | 2021-05-10 13:41:24 | Re: row filtering for logical replication |